Skip to content

BUG: overflow in astype(td64ns) #40008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 24, 2021
Merged

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@jreback jreback added the Timedelta Timedelta data type label Feb 24, 2021
@jreback jreback added this to the 1.3 milestone Feb 24, 2021
@jreback jreback added the Bug label Feb 24, 2021
@jreback jreback merged commit b761848 into pandas-dev:master Feb 24, 2021
@jreback
Copy link
Contributor

jreback commented Feb 24, 2021

seem to remember a bug report about this, but could be imagintion

@simonjayhawkins
Copy link
Member

@jbrockmendel
Copy link
Member Author

This results in a 5.22x slowdown in one of our benchmarks

Yah AFAICT this is unavoidable if we want to fix the bug. numpy/numpy#16352 is about fixing the astype upstream.

@jbrockmendel
Copy link
Member Author

BTW looking at the regressions listed, I think we can hit "ignore" for the TimestampProperties.time_freqstr ones, since those are driven by a deprecation of freqstr (and are still measured in ns)

@simonjayhawkins simonjayhawkins mentioned this pull request Jul 1, 2021
4 tasks
@simonjayhawkins
Copy link
Member

lts in a 5.22x slowdown in one of our benchmarks

Yah AFAICT this is unavoidable if we want to fix the bug. numpy/numpy#16352 is about fixing the astype upstream.

ok. have ignored https://simonjayhawkins.github.io/fantastic-dollop/#regressions?sort=3&dir=desc&branch=1.3.x

@jbrockmendel jbrockmendel mentioned this pull request Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Timedelta Timedelta data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants