-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: overflow in astype(td64ns) #40008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jbrockmendel
commented
Feb 23, 2021
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
seem to remember a bug report about this, but could be imagintion |
This results in a 5.22x slowdown in one of our benchmarks |
Yah AFAICT this is unavoidable if we want to fix the bug. numpy/numpy#16352 is about fixing the astype upstream. |
BTW looking at the regressions listed, I think we can hit "ignore" for the TimestampProperties.time_freqstr ones, since those are driven by a deprecation of freqstr (and are still measured in ns) |
ok. have ignored https://simonjayhawkins.github.io/fantastic-dollop/#regressions?sort=3&dir=desc&branch=1.3.x |